Author Topic: EDAF80 - Computer Graphics 2017 HT1  (Read 13699 times)

Offline MikeD

  • Full Member
  • ***
  • Posts: 211
EDAF80 - Computer Graphics 2017 HT1
« on: 2017-08-21 12:16:20 »
Welcome to the Computer graphics: Introduction to 3D discussion forum!  :)

Here you may ask questions about the labs or other issues. Teachers/assistants will be present here, but students are highly encouraged to participate.

Course-related announcements might pop up here as well, so make sure to stop by on a regular basis.

Editions from previous years (lots of useful stuff):
2016 forum: http://forum.student.lth.se/index.php/topic,12059.0.html
2015 forum: http://forum.student.lth.se/index.php/topic,12020.0.html
2014 forum: http://forum.student.lth.se/index.php/topic,11802.0.html
2013 forum: http://forum.student.lth.se/index.php/topic,1105.0.html
2012 forum: http://forum.student.lth.se/index.php/topic,1057.0.html
2011 forum: http://forum.student.lth.se/index.php/topic,999.0.html
2010 forum: http://forum.student.lth.se/index.php/topic,929.0.html

Offline Olle Alvin

  • Newbie
  • *
  • Posts: 4
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #1 on: 2017-08-29 10:16:41 »
Hello! I am looking for a lab partner  :)

Offline najera_angel

  • Newbie
  • *
  • Posts: 3
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #2 on: 2017-08-29 14:14:33 »
Hello! I am looking for a lab partner  :)


I don't have a lab partner so maybe we can partner up?

Offline Pierre Moreau

  • Full Member
  • ***
  • Posts: 202
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #3 on: 2017-08-29 14:37:01 »
Welcome to the course everyone!

Here are a few informations regarding the source code and running it on the lab computers:

  • It seems there has been some policy changes since last year, regarding programs that are allowed to run on the lab computers. As a result, you won't be able to get the labs compiling on the lab computers. We are working with the IT department to find a fix.
  • Similarly to previous years, you have to put the whole code under a folder named "Program" if you are working on the C drive (which is recommended) on the lab computers. See http://forum.student.lth.se/index.php/topic,12059.msg15772.html#msg15772 for more details.
  • If you use Visual Studio 2017, you do not need to interact with CMake: Visual Studio will do it for you. When you start Visual Studio 2017, just tell it to open the directory containing the root CMakeLists.txt file (same folder as the one containing `shaders` and `src`). After a few seconds it should automatically start processing the CMakeLists.txt file, and download the required libraries. Then, if you want to launch one of assignments, just select it in the "Select Startup Item" combobox (the one with a green arrow, similar to the "play"/"start" button), for example "EDAF80_Assignment1.exe". I'll add some updated informations about Visual Studio 2017 in the README file.

    However, Visual Studio 2017 throws an error in one of the 3rd party libraries used in the labs, assimp, whereas Visual Studio 2015, clang and GCC did not complain about it. So you will need to patch it manually. :-/ In "assimp/code/code/X3DImporter.cpp", edit lines 98 and 99 to make the function argument constant; you should get after edit, "bool operator==(const WordIterator &other) const { return start_ == other.start_; }", and similarly on line 99.
  • The code of the assignments is being improved on a bit, especially regarding the first assignment of this course. Changes should be pushed to the GitHub repository either by the end of today, or tomorrow. It would be better if you could wait for those changes before starting working on the assignments.

Offline Olle Alvin

  • Newbie
  • *
  • Posts: 4
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #4 on: 2017-08-29 16:05:33 »
Hello! I am looking for a lab partner  :)


I don't have a lab partner so maybe we can partner up?

Perfect! Let's sign up :)

Offline MagnusWa

  • Newbie
  • *
  • Posts: 3
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #5 on: 2017-08-30 09:23:39 »
I am looking for a lab partner  :)

Offline ChulMinPark

  • Newbie
  • *
  • Posts: 2
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #6 on: 2017-08-30 16:08:38 »
@Magnus Wa

do you want to partner up?

Offline Pierre Moreau

  • Full Member
  • ***
  • Posts: 202
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #7 on: 2017-08-30 17:30:35 »
The updated code is now available on GitHub, and contains among others:
  • An updated README that mentions how Visual Studio 2017 CMake support works (you no longer need to run CMake manually).
  • The CMake configuration has been updated to automatically patch assimp: you no longer need to patch assimp manually if you are using Visual Studio 2017
There shouldn’t be any more changes to the code, apart from potential bug fixes, so feel free to start using the (updated) code.

Offline JensM

  • Newbie
  • *
  • Posts: 4
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #8 on: 2017-08-30 19:43:06 »
I'm also looking for a lab partner  :)

Offline christian_oliveros

  • Newbie
  • *
  • Posts: 4
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #9 on: 2017-08-31 10:28:29 »
Hello,

I cloned the updated code but when I compile it with vs2017 it finds two errors on assimp's code.

These are the errors:

Code: [Select]
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.11.25503\include\algorithm(909): error C2678: binary '!=': no operator found which takes a left-hand operand of type 'Assimp::WordIterator' (or there is no acceptable conversion)

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.11.25503\include\algorithm(909): error C2088: '!=': illegal for struct [C:\Users\Christian\Documents\Lund\Project\Build\assimp\binary\code\assimp.vcxproj]

The full log and error log are attached to the post.

I will be grateful for any help, thanks

Offline DavidÅ

  • Newbie
  • *
  • Posts: 1
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #10 on: 2017-08-31 10:58:38 »
I'm also looking for a lab partner  :)
Also looking for a lab partner, do you want to partner up?

Offline Pierre Moreau

  • Full Member
  • ***
  • Posts: 202
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #11 on: 2017-08-31 11:17:57 »
Hello,

I cloned the updated code but when I compile it with vs2017 it finds two errors on assimp's code.

These are the errors:

Code: [Select]
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.11.25503\include\algorithm(909): error C2678: binary '!=': no operator found which takes a left-hand operand of type 'Assimp::WordIterator' (or there is no acceptable conversion)

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.11.25503\include\algorithm(909): error C2088: '!=': illegal for struct [C:\Users\Christian\Documents\Lund\Project\Build\assimp\binary\code\assimp.vcxproj]

Could you please check that you have a file named “0001-fix-compiling-problems-under-vs2017-3.patch” next to the “shaders” and “src” folders, and that “CMakeLists.txt” (in the same folder as the patch file) contains:
Code: [Select]
# assimp will not compile under VS2017.3 without that commit,
# which is not part of a release yet.
execute_process (
COMMAND ${GIT_EXECUTABLE} apply ${CMAKE_SOURCE_DIR}/0001-fix-compiling-problems-under-vs2017-3.patch
WORKING_DIRECTORY "${CMAKE_BINARY_DIR}/assimp/code"
)

Could you remove the whole “assimp” folder in “C:\Users\Christian\Documents\Lund\Project\Build” and restart the compilation afterwards? That should trigger CMake to redownload assimp and patch it.

Offline christian_oliveros

  • Newbie
  • *
  • Posts: 4
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #12 on: 2017-08-31 12:17:10 »
Thanks for your prompt reply.

Hello,

I cloned the updated code but when I compile it with vs2017 it finds two errors on assimp's code.

These are the errors:

Code: [Select]
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.11.25503\include\algorithm(909): error C2678: binary '!=': no operator found which takes a left-hand operand of type 'Assimp::WordIterator' (or there is no acceptable conversion)

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.11.25503\include\algorithm(909): error C2088: '!=': illegal for struct [C:\Users\Christian\Documents\Lund\Project\Build\assimp\binary\code\assimp.vcxproj]

Could you please check that you have a file named “0001-fix-compiling-problems-under-vs2017-3.patch” next to the “shaders” and “src” folders, and that “CMakeLists.txt” (in the same folder as the patch file) contains:
Code: [Select]
# assimp will not compile under VS2017.3 without that commit,
# which is not part of a release yet.
execute_process (
COMMAND ${GIT_EXECUTABLE} apply ${CMAKE_SOURCE_DIR}/0001-fix-compiling-problems-under-vs2017-3.patch
WORKING_DIRECTORY "${CMAKE_BINARY_DIR}/assimp/code"
)

Could you remove the whole “assimp” folder in “C:\Users\Christian\Documents\Lund\Project\Build” and restart the compilation afterwards? That should trigger CMake to redownload assimp and patch it.

I checked that I have the file for the patch and that the "CMakeLists.txt" contains those lines.

After deleting the "assimp" folder, I found in the log that the patch is not being applied to assimp because of an error.

Code: [Select]
error: patch failed: CMakeLists.txt:146
error: CMakeLists.txt: patch does not apply
error: patch failed: code/X3DImporter.cpp:95
error: code/X3DImporter.cpp: patch does not apply

The patch error log and the full log are attached to this post.

Offline MikaelRyd

  • Newbie
  • *
  • Posts: 3
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #13 on: 2017-08-31 12:18:07 »
Hi! I'm also looking for a lab partner!

Offline MagnusWa

  • Newbie
  • *
  • Posts: 3
Re: EDAF80 - Computer Graphics 2017 HT1
« Reply #14 on: 2017-08-31 12:28:43 »
@Magnus Wa

do you want to partner up?

Yes sure!